Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint project #3395

Merged
merged 10 commits into from
Dec 7, 2023
Merged

chore: lint project #3395

merged 10 commits into from
Dec 7, 2023

Conversation

KrzysztofMoch
Copy link
Member

@KrzysztofMoch KrzysztofMoch commented Dec 2, 2023 •
edited
Loading

Summary

Lint and format code (all changes are made by linters)
Most changes are made by linters. The only one made by me is 51a329e & e98a2c0

Testplan

  • should pass tests

@KrzysztofMoch
Copy link
Member Author

Nice, all green ✅ @freeboub @YangJonghun

@freeboub
Copy link
Collaborator

freeboub commented Dec 3, 2023

It would be better if you move back indent to 4 spaces, here we are loosing all the history :/

@YangJonghun
Copy link
Collaborator

@KrzysztofMoch
Looks good to me. I'd also suggest using Spotless, although it's not required.

@KrzysztofMoch
Copy link
Member Author

It would be better if you move back indent to 4 spaces, here we are loosing all the history :/

Done ✅

@KrzysztofMoch
Copy link
Member Author

@KrzysztofMoch Looks good to me. I'd also suggest using Spotless, although it's not required.

Thanks for suggestion 🙌, it looks good. But Spotless does not support swift, so implementing it only for android is not worth it IMO (Unless I haven't read about what useful magic feature ✨)

freeboub
freeboub requested changes Dec 6, 2023
View reviewed changes
android/src/main/java/com/brentvatne/common/API/SubtitleStyle.kt Show resolved Hide resolved
ios/Video/Features/RCTIMAAdsManager.swift
@@ -1,230 +1,209 @@
#if USE_GOOGLE_IMA
import Foundation
Copy link
Collaborator

@freeboub freeboub Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not very good ... Do you think there is a way to avoid that ?
This is not a blocking point !

@freeboub freeboub merged commit 800aee0 into TheWidlarzGroup:master Dec 7, 2023
9 checks passed
@KrzysztofMoch KrzysztofMoch deleted the chore/lint-project branch December 18, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrzysztofMoch @freeboub @YangJonghun